docker: cache volumes in build & debian for runtime#214
Merged
rtyler merged 1 commit intodelta-io:mainfrom Apr 8, 2025
Merged
Conversation
063febe to
a7606c4
Compare
rtyler
approved these changes
Apr 8, 2025
Member
rtyler
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I've validated it insofar as I can, we have some other build failures on main which are unrelated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Why
1. cache volumes
A clean build on my local machine takes about 30 mins. This is an attempt to
improve the iteration process by reducing the scope of changes that blow the
docker build cache and using docker volumes for large sections of the image that
are written during
cargo buildreducing recompilation of dependencies duringevery docker build.
2. debian runtime
The binary produced in by the rust image doesn't run inside the alpine
container. This switches the runtime of the final image to match the upstream
base image of the rust image that is used to build.